plotly / plotly/plotly.R

geom_GeomGeneArrow() and geom_GeomFitText() has yet to be implemented in plotly [shapviz]

未关闭
#2,149 4 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
R
星标
2.7k
派生
641
PR 合并指标
30 天内没有已合并 PR

描述

Recently I started working with the new shapviz package. In particular, the waterfall plot was working just fine for what I needed to visualise. Unfortunately, I was unable to use ggplotly to render the plots in plotly.

image

As it turns out, the waterfall plot is different from plotly's waterfall chart as it is built on the GeomGeneArrow geom from
from https://github.com/wilkox/gggenes.

Warning message in geom2trace.default(dots[[1L]][[1L]], dots[[2L]][[1L]], dots[[3L]][[1L]]):
“geom_GeomGeneArrow() has yet to be implemented in plotly.
  If you'd like to see this geom implemented,
  Please open an issue with your example code at
  [https://github.com/ropensci/plotly/issues](https://github.com/ropensci/plotly/issues)

In addition, geom_GeomFitText, which is needed for rendering text over plot elements is also unimplemented.

geom_GeomFitText() has yet to be implemented in plotly.
  If you'd like to see this geom implemented,
  Please open an issue with your example code at
  [https://github.com/ropensci/plotly/issues](https://github.com/ropensci/plotly/issues)

Reprex adapted from the default shapviz example below:

#library imports
install.packages("shapviz")
library(shapviz)
library(ggplot2)
library(xgboost)

set.seed(3653)

X <- diamonds[c("carat", "cut", "color", "clarity")]
dtrain <- xgb.DMatrix(data.matrix(X), label = diamonds$price)

fit <- xgb.train(
  params = list(learning_rate = 0.1, objective = "reg:squarederror"), 
  data = dtrain,
  nrounds = 65L
)

X_small <- X[sample(nrow(X), 2000L), ]

shp <- shapviz(fit, X_pred = data.matrix(X_small), X = X_small)
waterfall_plot <- sv_waterfall(shp, row_id = 1)

library(plotly)
ggplotly(waterfall_plot)

Expected Output should render similar to this (original ggplot):
image

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先通过 ggplotly(waterfall_plot) 运行所提供的 R reprex,并检查针对 GeomGeneArrow 和 GeomFitText 的 geom2trace.default 警告。将其行为与 gggenes/R/geom_gene_arrow.R 和 ggfittext geom 参考进行比较;完成的标准是 shapviz 瀑布图能够通过 ggplotly 渲染,且不出现任何未实现 geom 的警告。

由索引模型根据 Issue 内容生成。

评估

技术栈
r
领域
data-visualization
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
基本清楚
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。