elsewhencode / elsewhencode/project-guidelines

Guidelines too opinionated about squashing commits on develop

Đang mở
#124 2 bình luận 6 reaction 1 người được giao Được @vpanjganj nhận Xem trên GitHub
help wanted improvement
Ngôn ngữ chính
JavaScript
Star
29.4k
Fork
3.1k
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

In 1.2, we can read the following:

> You can use --autosquash to squash all your commits to a single commit. **Nobody wants** many commits for a single feature in develop branch. read more...

I think that asserting that nobody wants that is a fallacy. There are good reasons for which you would want to keep those commits separated even in develop branch:
- know what the reason of a change was when doing a git blame, which is naturally in the commit message/description and not in the feature
- having more precision for git bisect: squashing makes you lose information as you only know which feature caused a regression, rather than a specific commit (the latter narrows the scope)

Those are the reasons why I never squash my commits into a feature commit. You should therefore mention in your guidelines that this is subjective.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.