elsewhencode / elsewhencode/project-guidelines

Guidelines too opinionated about squashing commits on develop

Ouverte
#124 2 commentaires 6 réactions 1 personne assignée Réclamée par @vpanjganj Voir sur GitHub
help wanted improvement
Langage dominant
JavaScript
Étoiles
29.4k
Forks
3.1k
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

In 1.2, we can read the following:

> You can use --autosquash to squash all your commits to a single commit. **Nobody wants** many commits for a single feature in develop branch. read more...

I think that asserting that nobody wants that is a fallacy. There are good reasons for which you would want to keep those commits separated even in develop branch:
- know what the reason of a change was when doing a git blame, which is naturally in the commit message/description and not in the feature
- having more precision for git bisect: squashing makes you lose information as you only know which feature caused a regression, rather than a specific commit (the latter narrows the scope)

Those are the reasons why I never squash my commits into a feature commit. You should therefore mention in your guidelines that this is subjective.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.