elsewhencode / elsewhencode/project-guidelines

Guidelines too opinionated about squashing commits on develop

Aperta
#124 2 commenti 6 reazioni 1 assegnatario Rivendicata da @vpanjganj Vedi su GitHub
help wanted improvement
Lingua principale
JavaScript
Stelle
29.4k
Fork
3.1k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

In 1.2, we can read the following:

> You can use --autosquash to squash all your commits to a single commit. **Nobody wants** many commits for a single feature in develop branch. read more...

I think that asserting that nobody wants that is a fallacy. There are good reasons for which you would want to keep those commits separated even in develop branch:
- know what the reason of a change was when doing a git blame, which is naturally in the commit message/description and not in the feature
- having more precision for git bisect: squashing makes you lose information as you only know which feature caused a regression, rather than a specific commit (the latter narrows the scope)

Those are the reasons why I never squash my commits into a feature commit. You should therefore mention in your guidelines that this is subjective.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.