elsewhencode / elsewhencode/project-guidelines

Guidelines too opinionated about squashing commits on develop

未关闭
#124 2 条评论 6 个 reaction 已指派 1 人 已被 @vpanjganj 认领 在 GitHub 查看
help wanted improvement
主要语言
JavaScript
星标
29.4k
派生
3.1k
PR 合并指标
30 天内没有已合并 PR

描述

In 1.2, we can read the following:

> You can use --autosquash to squash all your commits to a single commit. **Nobody wants** many commits for a single feature in develop branch. read more...

I think that asserting that nobody wants that is a fallacy. There are good reasons for which you would want to keep those commits separated even in develop branch:
- know what the reason of a change was when doing a git blame, which is naturally in the commit message/description and not in the feature
- having more precision for git bisect: squashing makes you lose information as you only know which feature caused a regression, rather than a specific commit (the latter narrows the scope)

Those are the reasons why I never squash my commits into a feature commit. You should therefore mention in your guidelines that this is subjective.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。