elsewhencode / elsewhencode/project-guidelines

Guidelines too opinionated about squashing commits on develop

Aberta
#124 2 comentários 6 reações 1 responsável Reivindicada por @vpanjganj Ver no GitHub
help wanted improvement
Linguagem predominante
JavaScript
Estrelas
29.4k
Forks
3.1k
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

In 1.2, we can read the following:

> You can use --autosquash to squash all your commits to a single commit. **Nobody wants** many commits for a single feature in develop branch. read more...

I think that asserting that nobody wants that is a fallacy. There are good reasons for which you would want to keep those commits separated even in develop branch:
- know what the reason of a change was when doing a git blame, which is naturally in the commit message/description and not in the feature
- having more precision for git bisect: squashing makes you lose information as you only know which feature caused a regression, rather than a specific commit (the latter narrows the scope)

Those are the reasons why I never squash my commits into a feature commit. You should therefore mention in your guidelines that this is subjective.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.