elsewhencode / elsewhencode/project-guidelines

Guidelines too opinionated about squashing commits on develop

Abierto
#124 2 comentarios 6 reacciones 1 asignado Reclamado por @vpanjganj Ver en GitHub
help wanted improvement
Lenguaje dominante
JavaScript
Estrellas
29.4k
Forks
3.1k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

In 1.2, we can read the following:

> You can use --autosquash to squash all your commits to a single commit. **Nobody wants** many commits for a single feature in develop branch. read more...

I think that asserting that nobody wants that is a fallacy. There are good reasons for which you would want to keep those commits separated even in develop branch:
- know what the reason of a change was when doing a git blame, which is naturally in the commit message/description and not in the feature
- having more precision for git bisect: squashing makes you lose information as you only know which feature caused a regression, rather than a specific commit (the latter narrows the scope)

Those are the reasons why I never squash my commits into a feature commit. You should therefore mention in your guidelines that this is subjective.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.