elsewhencode / elsewhencode/project-guidelines

Guidelines too opinionated about squashing commits on develop

オープン
#124 コメント 2 件 リアクション 6 件 担当者 1 名 @vpanjganj が担当を希望しています GitHub で見る
help wanted improvement
主要言語
JavaScript
スター
29.4k
フォーク
3.1k
PR マージ指標
30日以内にマージされた PR はありません

説明

In 1.2, we can read the following:

> You can use --autosquash to squash all your commits to a single commit. **Nobody wants** many commits for a single feature in develop branch. read more...

I think that asserting that nobody wants that is a fallacy. There are good reasons for which you would want to keep those commits separated even in develop branch:
- know what the reason of a change was when doing a git blame, which is naturally in the commit message/description and not in the feature
- having more precision for git bisect: squashing makes you lose information as you only know which feature caused a regression, rather than a specific commit (the latter narrows the scope)

Those are the reasons why I never squash my commits into a feature commit. You should therefore mention in your guidelines that this is subjective.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。