patternfly / patternfly/patternfly-react
DashboardWrapper demo updates
Chưa có ai nhận issue này.
- Ngôn ngữ chính
- TypeScript
- Star
- 862
- Fork
- 392
- Merge trung bình
- 4 ngày 8 giờ
- Pull request đã merge (30 ngày)
- 9
Mô tả
re: https://github.com/patternfly/patternfly-react/pull/7927#pullrequestreview-1125650784
I think we want the vertical nav's aria-label to be "Global", otherwise the rotor reads this as "Nav navigation". "Global" is the default, so if we want to update, you could remove this entirely. This also matches the <PageToggleButton>'s aria-label, and those labels should probably match.
A bunch of the demos have body text that references the Overpass font and some specific font styles that aren't relevant and may change (and be incorrect) as styles change over time. Just in general, I'd say we should review the body text of demos/examples and make sure we don't have other stuff like this. Here's a list of the places I found that reference the overpass text
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Banner.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Banner.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/examples/BackToTop/BackToTopNameDemo.tsx: Body text should be Overpass Regular at 16px.It should have leading of 24px because
packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-table/src//docs/examples/ComposableTableStickyToolbar.tsx: Body text should be Overpass Regular at 16px. It should have leading of 24px because
This page section should be isWidthLimited, or maybe some mechanism to add/remove that depending on what else is on the page (like if other page sections aren't width limited?), though I'm not sure if there is ever a use case where this wouldn't be width limited. I guess it doesn't matter here since the text isn't very long, but if more content is added, it will keep it from spanning the whole viewport.
Jira Issue: PF-169
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Hướng nghiên cứu
Bắt đầu với packages/react-core/src/demos/examples/DashboardWrapper.js và DashboardHeader.js, sau đó xem lại các tệp Markdown và TSX của demo được liệt kê để tìm các tham chiếu đến Overpass. Được xem là hoàn tất khi các nhãn điều hướng và hành vi về độ rộng của các phần trên trang khớp với yêu cầu, đồng thời văn bản demo không còn chứa hướng dẫn lỗi thời về phông chữ trong các tệp đã xác định.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- markdown, react, typescript
- Lĩnh vực
- accessibility, documentation, frontend
- Loại issue
- Tài liệu
- Độ khó
- 4/5
- Thời gian dự kiến
- 3-5 ngày
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 35/100