patternfly / patternfly/patternfly-react

DashboardWrapper demo updates

未关闭
#8,130 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

PF Team Pinned
主要语言
TypeScript
星标
862
派生
392
平均合并
4 天 8 小时
30 天内合并 PR
9

描述

re: https://github.com/patternfly/patternfly-react/pull/7927#pullrequestreview-1125650784

I think we want the vertical nav's aria-label to be "Global", otherwise the rotor reads this as "Nav navigation". "Global" is the default, so if we want to update, you could remove this entirely. This also matches the <PageToggleButton>'s aria-label, and those labels should probably match.

https://github.com/patternfly/patternfly-react/blob/22fc7d8e8189ef2da0eb483a8c35c4c0e2be3807/packages/react-core/src/demos/examples/DashboardWrapper.js#L73

https://github.com/patternfly/patternfly-react/blob/22fc7d8e8189ef2da0eb483a8c35c4c0e2be3807/packages/react-core/src/demos/examples/DashboardHeader.js#L220


A bunch of the demos have body text that references the Overpass font and some specific font styles that aren't relevant and may change (and be incorrect) as styles change over time. Just in general, I'd say we should review the body text of demos/examples and make sure we don't have other stuff like this. Here's a list of the places I found that reference the overpass text

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Banner.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Banner.md:                    Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/examples/BackToTop/BackToTopNameDemo.tsx:              Body text should be Overpass Regular at 16px.It should have leading of 24px because 

packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-table/src//docs/examples/ComposableTableStickyToolbar.tsx:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 


This page section should be isWidthLimited, or maybe some mechanism to add/remove that depending on what else is on the page (like if other page sections aren't width limited?), though I'm not sure if there is ever a use case where this wouldn't be width limited. I guess it doesn't matter here since the text isn't very long, but if more content is added, it will keep it from spanning the whole viewport.

https://github.com/patternfly/patternfly-react/blob/22fc7d8e8189ef2da0eb483a8c35c4c0e2be3807/packages/react-core/src/demos/examples/DashboardWrapper.js#L29-L34


Jira Issue: PF-169

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

先从 packages/react-core/src/demos/examples/DashboardWrapper.js 和 DashboardHeader.js 开始,然后检查列出的 demo Markdown 和 TSX 文件中的 Overpass 引用。导航标签和页面分区宽度行为符合请求,并且已识别文件中的 demo 文本不再包含过时的字体指导,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
markdown, react, typescript
领域
accessibility, documentation, frontend
Issue 类型
文档
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。