patternfly / patternfly/patternfly-react

DashboardWrapper demo updates

Ouverte
#8,130 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

PF Team Pinned
Langage dominant
TypeScript
Étoiles
862
Forks
392
Merge moyen
4 j 8 h
PR mergées (30 j)
9

Description

re: https://github.com/patternfly/patternfly-react/pull/7927#pullrequestreview-1125650784

I think we want the vertical nav's aria-label to be "Global", otherwise the rotor reads this as "Nav navigation". "Global" is the default, so if we want to update, you could remove this entirely. This also matches the <PageToggleButton>'s aria-label, and those labels should probably match.

https://github.com/patternfly/patternfly-react/blob/22fc7d8e8189ef2da0eb483a8c35c4c0e2be3807/packages/react-core/src/demos/examples/DashboardWrapper.js#L73

https://github.com/patternfly/patternfly-react/blob/22fc7d8e8189ef2da0eb483a8c35c4c0e2be3807/packages/react-core/src/demos/examples/DashboardHeader.js#L220


A bunch of the demos have body text that references the Overpass font and some specific font styles that aren't relevant and may change (and be incorrect) as styles change over time. Just in general, I'd say we should review the body text of demos/examples and make sure we don't have other stuff like this. Here's a list of the places I found that reference the overpass text

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Banner.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Banner.md:                    Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/examples/BackToTop/BackToTopNameDemo.tsx:              Body text should be Overpass Regular at 16px.It should have leading of 24px because 

packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-table/src//docs/examples/ComposableTableStickyToolbar.tsx:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 


This page section should be isWidthLimited, or maybe some mechanism to add/remove that depending on what else is on the page (like if other page sections aren't width limited?), though I'm not sure if there is ever a use case where this wouldn't be width limited. I guess it doesn't matter here since the text isn't very long, but if more content is added, it will keep it from spanning the whole viewport.

https://github.com/patternfly/patternfly-react/blob/22fc7d8e8189ef2da0eb483a8c35c4c0e2be3807/packages/react-core/src/demos/examples/DashboardWrapper.js#L29-L34


Jira Issue: PF-169

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez par packages/react-core/src/demos/examples/DashboardWrapper.js et DashboardHeader.js, puis examinez les fichiers Markdown et TSX de démonstration indiqués pour y trouver les références à Overpass. Le travail est terminé lorsque les libellés de navigation et le comportement de la largeur des sections de page correspondent à la demande, et que le texte des démonstrations ne contient plus les anciennes indications concernant la police dans les fichiers identifiés.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
markdown, react, typescript
Domaine
accessibility, documentation, frontend
Type d'issue
Documentation
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.