patternfly / patternfly/patternfly-react
DashboardWrapper demo updates
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- TypeScript
- Estrellas
- 862
- Forks
- 392
- Merge medio
- 4 d 8 h
- PR fusionados (30 d)
- 9
Descripción
re: https://github.com/patternfly/patternfly-react/pull/7927#pullrequestreview-1125650784
I think we want the vertical nav's aria-label to be "Global", otherwise the rotor reads this as "Nav navigation". "Global" is the default, so if we want to update, you could remove this entirely. This also matches the <PageToggleButton>'s aria-label, and those labels should probably match.
A bunch of the demos have body text that references the Overpass font and some specific font styles that aren't relevant and may change (and be incorrect) as styles change over time. Just in general, I'd say we should review the body text of demos/examples and make sure we don't have other stuff like this. Here's a list of the places I found that reference the overpass text
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Banner.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Banner.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/examples/BackToTop/BackToTopNameDemo.tsx: Body text should be Overpass Regular at 16px.It should have leading of 24px because
packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-table/src//docs/examples/ComposableTableStickyToolbar.tsx: Body text should be Overpass Regular at 16px. It should have leading of 24px because
This page section should be isWidthLimited, or maybe some mechanism to add/remove that depending on what else is on the page (like if other page sections aren't width limited?), though I'm not sure if there is ever a use case where this wouldn't be width limited. I guess it doesn't matter here since the text isn't very long, but if more content is added, it will keep it from spanning the whole viewport.
Jira Issue: PF-169
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con packages/react-core/src/demos/examples/DashboardWrapper.js y DashboardHeader.js; después, revisa los archivos Markdown y TSX de demos indicados para localizar las referencias a Overpass. Se considera terminado cuando las etiquetas de navegación y el comportamiento del ancho de las secciones de la página coincidan con la solicitud, y el texto de las demos ya no contenga las indicaciones obsoletas sobre la fuente en los archivos identificados.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- markdown, react, typescript
- Área
- accessibility, documentation, frontend
- Tipo de issue
- Documentación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100