patternfly / patternfly/patternfly-react
DashboardWrapper demo updates
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 862
- Forks
- 392
- Ø Merge
- 4 T. 8 Std.
- Gemergte PRs (30 T.)
- 9
Beschreibung
re: https://github.com/patternfly/patternfly-react/pull/7927#pullrequestreview-1125650784
I think we want the vertical nav's aria-label to be "Global", otherwise the rotor reads this as "Nav navigation". "Global" is the default, so if we want to update, you could remove this entirely. This also matches the <PageToggleButton>'s aria-label, and those labels should probably match.
A bunch of the demos have body text that references the Overpass font and some specific font styles that aren't relevant and may change (and be incorrect) as styles change over time. Just in general, I'd say we should review the body text of demos/examples and make sure we don't have other stuff like this. Here's a list of the places I found that reference the overpass text
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Nav.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/PrimaryDetail.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Banner.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/Banner.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/examples/BackToTop/BackToTopNameDemo.tsx: Body text should be Overpass Regular at 16px.It should have leading of 24px because
packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md: Body text should be Overpass Regular at 16px. It should have leading of 24px because
packages/react-table/src//docs/examples/ComposableTableStickyToolbar.tsx: Body text should be Overpass Regular at 16px. It should have leading of 24px because
This page section should be isWidthLimited, or maybe some mechanism to add/remove that depending on what else is on the page (like if other page sections aren't width limited?), though I'm not sure if there is ever a use case where this wouldn't be width limited. I guess it doesn't matter here since the text isn't very long, but if more content is added, it will keep it from spanning the whole viewport.
Jira Issue: PF-169
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit packages/react-core/src/demos/examples/DashboardWrapper.js und DashboardHeader.js und überprüfe anschließend die aufgeführten Demo-Markdown- und TSX-Dateien auf die Overpass-Verweise. Als erledigt gilt die Aufgabe, wenn die Navigationsbezeichnungen und das Verhalten der Seitenbereichsbreite der Anforderung entsprechen und der Demotext in den identifizierten Dateien keine veralteten Hinweise zur Schriftart mehr enthält.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- markdown, react, typescript
- Bereich
- accessibility, documentation, frontend
- Issue-Typ
- Dokumentation
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100