patternfly / patternfly/patternfly-react

DashboardWrapper demo updates

オープン
#8,130 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

PF Team Pinned
主要言語
TypeScript
スター
862
フォーク
392
平均マージ
4日 8時間
マージ済み PR(30日)
9

説明

re: https://github.com/patternfly/patternfly-react/pull/7927#pullrequestreview-1125650784

I think we want the vertical nav's aria-label to be "Global", otherwise the rotor reads this as "Nav navigation". "Global" is the default, so if we want to update, you could remove this entirely. This also matches the <PageToggleButton>'s aria-label, and those labels should probably match.

https://github.com/patternfly/patternfly-react/blob/22fc7d8e8189ef2da0eb483a8c35c4c0e2be3807/packages/react-core/src/demos/examples/DashboardWrapper.js#L73

https://github.com/patternfly/patternfly-react/blob/22fc7d8e8189ef2da0eb483a8c35c4c0e2be3807/packages/react-core/src/demos/examples/DashboardHeader.js#L220


A bunch of the demos have body text that references the Overpass font and some specific font styles that aren't relevant and may change (and be incorrect) as styles change over time. Just in general, I'd say we should review the body text of demos/examples and make sure we don't have other stuff like this. Here's a list of the places I found that reference the overpass text

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Banner.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/Banner.md:                    Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/examples/BackToTop/BackToTopNameDemo.tsx:              Body text should be Overpass Regular at 16px.It should have leading of 24px because 

packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because 

packages/react-table/src//docs/examples/ComposableTableStickyToolbar.tsx:              Body text should be Overpass Regular at 16px. It should have leading of 24px because 


This page section should be isWidthLimited, or maybe some mechanism to add/remove that depending on what else is on the page (like if other page sections aren't width limited?), though I'm not sure if there is ever a use case where this wouldn't be width limited. I guess it doesn't matter here since the text isn't very long, but if more content is added, it will keep it from spanning the whole viewport.

https://github.com/patternfly/patternfly-react/blob/22fc7d8e8189ef2da0eb483a8c35c4c0e2be3807/packages/react-core/src/demos/examples/DashboardWrapper.js#L29-L34


Jira Issue: PF-169

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

まず packages/react-core/src/demos/examples/DashboardWrapper.js と DashboardHeader.js から始め、続いて一覧にあるデモの Markdown ファイルと TSX ファイルを確認して Overpass への参照を調べます。ナビゲーションラベルとページセクションの幅の挙動が要求どおりになり、特定したファイルのデモテキストに古いフォントに関する案内が残っていなければ完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
markdown, react, typescript
領域
accessibility, documentation, frontend
issue の種類
ドキュメント
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。