googleapis / googleapis/google-http-java-client
Lost exceptions: printStackTrace VS log
Đang mở
type: cleanup
- Ngôn ngữ chính
- Java
- Star
- 1.4k
- Fork
- 473
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
Hi,
I bumped into this.
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L170
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L172
I think it's really bad to print exceptions to the console. Those exceptions are basically lost, aren't they?
Why don't we log instead?
Thanks.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.