googleapis / googleapis/google-http-java-client
Lost exceptions: printStackTrace VS log
Open
type: cleanup
- Dominant language
- Java
- Stars
- 1.4k
- Forks
- 473
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I bumped into this.
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L170
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L172
I think it's really bad to print exceptions to the console. Those exceptions are basically lost, aren't they?
Why don't we log instead?
Thanks.
Contributor guide
Assessment
This issue has not been assessed yet.