googleapis / googleapis/google-http-java-client

Lost exceptions: printStackTrace VS log

未关闭
#1,402 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
type: cleanup
主要语言
Java
星标
1.4k
派生
473
PR 合并指标
30 天内没有已合并 PR

描述

Hi,

I bumped into this.

https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L170

https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L172

I think it's really bad to print exceptions to the console. Those exceptions are basically lost, aren't they?

Why don't we log instead?

Thanks.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。