googleapis / googleapis/google-http-java-client
Lost exceptions: printStackTrace VS log
Aperta
type: cleanup
- Lingua principale
- Java
- Stelle
- 1.4k
- Fork
- 473
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Hi,
I bumped into this.
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L170
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L172
I think it's really bad to print exceptions to the console. Those exceptions are basically lost, aren't they?
Why don't we log instead?
Thanks.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.