googleapis / googleapis/google-http-java-client
Lost exceptions: printStackTrace VS log
Ouverte
type: cleanup
- Langage dominant
- Java
- Étoiles
- 1.4k
- Forks
- 473
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Hi,
I bumped into this.
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L170
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L172
I think it's really bad to print exceptions to the console. Those exceptions are basically lost, aren't they?
Why don't we log instead?
Thanks.
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.