googleapis / googleapis/google-http-java-client
Lost exceptions: printStackTrace VS log
Abierto
type: cleanup
- Lenguaje dominante
- Java
- Estrellas
- 1.4k
- Forks
- 473
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
Hi,
I bumped into this.
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L170
https://github.com/googleapis/google-http-java-client/blob/8c24855ffc3d44cb62d838ff6dace6ed530f9c38/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#L172
I think it's really bad to print exceptions to the console. Those exceptions are basically lost, aren't they?
Why don't we log instead?
Thanks.
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.