PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Physical to Elemental Conversion
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
I have the following allocated in game and in PoB:
- Level 20/20 Anomalous Tornado Shot (60% converted to random elemental)
- 40% physical to cold mastery
- 35% physical to cold while affected by hatred watcher's eye
My in game tooltip shows I still have a portion of damage being dealt as physical (it is enough to kill me in physical reflect maps). PoB calculations show I have over 100% physical converted to elemental and deal no elemental damage.
I believe the conversion from tree/gear is additive, but the conversion from the gem itself is multiplicative - therefore I would have 75% phys to cold, 15% phys to random element, 10% phys based on the above example.
What is the value from the calculation in Path of Building?
Path of Building is calculating my physical conversion as over 100% when the in game tooltip still shows physical damage remaining.
How to reproduce the issue
No response
Character build code
https://pobb.in/U0OVGTrNyDvO
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked character build code and the physical-conversion calculation it reproduces in Path of Building. Compare the reported conversion with the in-game tooltip and physical-reflect behavior described in the issue. Done means the conversion result matches the documented in-game behavior for this build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100