microsoft / microsoft/vscode-pull-request-github
Comments creation is failing silently, with the illusion of "Pending" comments that saved on the server
@alexr00 đang làm issue này rồi.
Từ ngày 8/12/2022.
- Ngôn ngữ chính
- TypeScript
- Star
- 2.6k
- Fork
- 795
- Merge trung bình
- 1 ngày 4 giờ
- Pull request đã merge (30 ngày)
- 46
Mô tả
- Extension version: v0.54.1
- VSCode Version: 1.73.1
- OS: MacOS
Steps to Reproduce:
- Start a review and wait for a while (maybe until the session is expired)
- Try to write a comment and then edit it or comment in the thread
Comments creation is failing silently
After a few hours of code review on a massive PR, I noticed an error when I commented on another comment on one of my threads.
Creating comment failed: Error: Cannot reply to temporary comment
I tried to save the comments without success, and I realized that none of the comments that I made in recent hours did save on GitHub as a "Pending" comment as always. It was just an optimistic UI that gave me the illusion that the comments were saved in GitHub, but it held my comments in memory.
I can't determine what caused the bug. Maybe it was because time passed and my session got expired or something like that (We're login into GitHub with SSO, and the session is limited to a few hours)
I cannot find out because everything is failing silently until I comment in the thread/edit a comment, and even then, there is no relevant log-in console in the extension output pane (see the attached video)
https://user-images.githubusercontent.com/5693018/205736222-4496ebc0-10c2-4838-8703-90834b2ebc19.mp4
Besides the unknown cause of the bug, it's just a very bad idea to save the comments in memory.
This optimistic UI gave me the illusion that everything was fine and made me lose many work hours.
We can't rely on and use it for our PR's anymore
Hướng dẫn đóng góp
Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Đánh giá
Issue này chưa được đánh giá.