microsoft / microsoft/vscode-pull-request-github

Comments creation is failing silently, with the illusion of "Pending" comments that saved on the server

オープン
#4,291 コメント 8 件 リアクション 8 件 担当者 1 名 GitHub で見る

@alexr00 がすでに取り組んでいます。

2022年12月8日 から。

bug
主要言語
TypeScript
スター
2.6k
フォーク
795
平均マージ
1日 4時間
マージ済み PR(30日)
46

説明

  • Extension version: v0.54.1
  • VSCode Version: 1.73.1
  • OS: MacOS

Steps to Reproduce:

  1. Start a review and wait for a while (maybe until the session is expired)
  2. Try to write a comment and then edit it or comment in the thread

Comments creation is failing silently

After a few hours of code review on a massive PR, I noticed an error when I commented on another comment on one of my threads.
Creating comment failed: Error: Cannot reply to temporary comment

I tried to save the comments without success, and I realized that none of the comments that I made in recent hours did save on GitHub as a "Pending" comment as always. It was just an optimistic UI that gave me the illusion that the comments were saved in GitHub, but it held my comments in memory.

I can't determine what caused the bug. Maybe it was because time passed and my session got expired or something like that (We're login into GitHub with SSO, and the session is limited to a few hours)
I cannot find out because everything is failing silently until I comment in the thread/edit a comment, and even then, there is no relevant log-in console in the extension output pane (see the attached video)

https://user-images.githubusercontent.com/5693018/205736222-4496ebc0-10c2-4838-8703-90834b2ebc19.mp4

Besides the unknown cause of the bug, it's just a very bad idea to save the comments in memory.
This optimistic UI gave me the illusion that everything was fine and made me lose many work hours.
We can't rely on and use it for our PR's anymore

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。