microsoft / microsoft/vscode-pull-request-github

Comments creation is failing silently, with the illusion of "Pending" comments that saved on the server

Open
#4,291 8 comments 8 reactions 1 assignee View on GitHub

@alexr00 is already working on this.

Since Dec 8, 2022.

bug
Dominant language
TypeScript
Stars
2.6k
Forks
795
Avg merge
1d 4h
Merged PRs (30d)
46

Description

  • Extension version: v0.54.1
  • VSCode Version: 1.73.1
  • OS: MacOS

Steps to Reproduce:

  1. Start a review and wait for a while (maybe until the session is expired)
  2. Try to write a comment and then edit it or comment in the thread

Comments creation is failing silently

After a few hours of code review on a massive PR, I noticed an error when I commented on another comment on one of my threads.
Creating comment failed: Error: Cannot reply to temporary comment

I tried to save the comments without success, and I realized that none of the comments that I made in recent hours did save on GitHub as a "Pending" comment as always. It was just an optimistic UI that gave me the illusion that the comments were saved in GitHub, but it held my comments in memory.

I can't determine what caused the bug. Maybe it was because time passed and my session got expired or something like that (We're login into GitHub with SSO, and the session is limited to a few hours)
I cannot find out because everything is failing silently until I comment in the thread/edit a comment, and even then, there is no relevant log-in console in the extension output pane (see the attached video)

https://user-images.githubusercontent.com/5693018/205736222-4496ebc0-10c2-4838-8703-90834b2ebc19.mp4

Besides the unknown cause of the bug, it's just a very bad idea to save the comments in memory.
This optimistic UI gave me the illusion that everything was fine and made me lose many work hours.
We can't rely on and use it for our PR's anymore

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.