microsoft / microsoft/vscode-pull-request-github

Comments creation is failing silently, with the illusion of "Pending" comments that saved on the server

Aperta
#4,291 8 commenti 8 reazioni 1 assegnatario Vedi su GitHub

@alexr00 ci sta già lavorando.

Dal 8/12/2022.

bug
Lingua principale
TypeScript
Stelle
2.6k
Fork
795
Merge medio
1g 4h
PR unite (30g)
46

Descrizione

  • Extension version: v0.54.1
  • VSCode Version: 1.73.1
  • OS: MacOS

Steps to Reproduce:

  1. Start a review and wait for a while (maybe until the session is expired)
  2. Try to write a comment and then edit it or comment in the thread

Comments creation is failing silently

After a few hours of code review on a massive PR, I noticed an error when I commented on another comment on one of my threads.
Creating comment failed: Error: Cannot reply to temporary comment

I tried to save the comments without success, and I realized that none of the comments that I made in recent hours did save on GitHub as a "Pending" comment as always. It was just an optimistic UI that gave me the illusion that the comments were saved in GitHub, but it held my comments in memory.

I can't determine what caused the bug. Maybe it was because time passed and my session got expired or something like that (We're login into GitHub with SSO, and the session is limited to a few hours)
I cannot find out because everything is failing silently until I comment in the thread/edit a comment, and even then, there is no relevant log-in console in the extension output pane (see the attached video)

https://user-images.githubusercontent.com/5693018/205736222-4496ebc0-10c2-4838-8703-90834b2ebc19.mp4

Besides the unknown cause of the bug, it's just a very bad idea to save the comments in memory.
This optimistic UI gave me the illusion that everything was fine and made me lose many work hours.
We can't rely on and use it for our PR's anymore

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.