microsoft / microsoft/vscode-pull-request-github

Comments creation is failing silently, with the illusion of "Pending" comments that saved on the server

Ouverte
#4,291 8 commentaires 8 réactions 1 personne assignée Voir sur GitHub

@alexr00 y travaille déjà.

Depuis le 8/12/2022.

bug
Langage dominant
TypeScript
Étoiles
2.6k
Forks
795
Merge moyen
1 j 4 h
PR mergées (30 j)
46

Description

  • Extension version: v0.54.1
  • VSCode Version: 1.73.1
  • OS: MacOS

Steps to Reproduce:

  1. Start a review and wait for a while (maybe until the session is expired)
  2. Try to write a comment and then edit it or comment in the thread

Comments creation is failing silently

After a few hours of code review on a massive PR, I noticed an error when I commented on another comment on one of my threads.
Creating comment failed: Error: Cannot reply to temporary comment

I tried to save the comments without success, and I realized that none of the comments that I made in recent hours did save on GitHub as a "Pending" comment as always. It was just an optimistic UI that gave me the illusion that the comments were saved in GitHub, but it held my comments in memory.

I can't determine what caused the bug. Maybe it was because time passed and my session got expired or something like that (We're login into GitHub with SSO, and the session is limited to a few hours)
I cannot find out because everything is failing silently until I comment in the thread/edit a comment, and even then, there is no relevant log-in console in the extension output pane (see the attached video)

https://user-images.githubusercontent.com/5693018/205736222-4496ebc0-10c2-4838-8703-90834b2ebc19.mp4

Besides the unknown cause of the bug, it's just a very bad idea to save the comments in memory.
This optimistic UI gave me the illusion that everything was fine and made me lose many work hours.
We can't rely on and use it for our PR's anymore

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.