micro-ROS / micro-ROS/micro_ros_espidf_component
embeddedRTPS build issue
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 419
- Forks
- 124
- Avg merge
- 21h 35m
- Merged PRs (30d)
- 3
Description
`embeddedRTPS` failed to build in CI. This is because [`ament_cmake` recently removed `ament_cmake_target_dependencies`](https://github.com/ament/ament_cmake/pull/614). However, `micro-ROS/embeddedRTPS`, `micro-ROS/rmw_embeddedrtps`, and `micro-ROS/rcl` are still using it. The call in `micro-ROS/rcl` is wrapped with `if(NOT RCL_MICROROS)`, so it doesn't trigger during the build.
An AI provided me with a very hacky (but working) workaround — adding `ament_target_dependencies.cmake` back into `ament_cmake` during the build... But I think it's better to update the three libraries mentioned above.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ament_cmake_target_dependencies calls in micro-ROS/embeddedRTPS, micro-ROS/rmw_embeddedrtps, and micro-ROS/rcl, noting the conditional use in rcl. Check the embeddedRTPS CI build and verify that all three libraries build without restoring the removed ament_cmake file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake
- Domain
- build-system, embedded-iot
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100