googleapis / googleapis/google-cloud-java
[sdk-platform-java] Remove internet request in unit tests
Đang mở
priority: p2
type: feature request
- Ngôn ngữ chính
- Java
- Star
- 2.1k
- Fork
- 1.2k
- Merge trung bình
- 1 ngày 23 giờ
- Pull request đã merge (30 ngày)
- 154
Mô tả
The unit tests in `hermetic_build/release_note_generation/tests/generate_pr_description_unit_tests.py` have real `git clone` and `git checkout`. However, it is not a best practice for unit tests to depend on internet request as it is slow and flaky.
We should mock these operations to make the unit tests quick and deterministic.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.