googleapis / googleapis/google-cloud-java
[sdk-platform-java] Remove internet request in unit tests
Ouverte
priority: p2
type: feature request
- Langage dominant
- Java
- Étoiles
- 2.1k
- Forks
- 1.2k
- Merge moyen
- 1 j 23 h
- PR mergées (30 j)
- 154
Description
The unit tests in `hermetic_build/release_note_generation/tests/generate_pr_description_unit_tests.py` have real `git clone` and `git checkout`. However, it is not a best practice for unit tests to depend on internet request as it is slow and flaky.
We should mock these operations to make the unit tests quick and deterministic.
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.