googleapis / googleapis/google-cloud-java
[sdk-platform-java] Remove internet request in unit tests
Abierto
priority: p2
type: feature request
- Lenguaje dominante
- Java
- Estrellas
- 2.1k
- Forks
- 1.2k
- Merge medio
- 1 d 23 h
- PR fusionados (30 d)
- 154
Descripción
The unit tests in `hermetic_build/release_note_generation/tests/generate_pr_description_unit_tests.py` have real `git clone` and `git checkout`. However, it is not a best practice for unit tests to depend on internet request as it is slow and flaky.
We should mock these operations to make the unit tests quick and deterministic.
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.