googleapis / googleapis/google-cloud-java
[sdk-platform-java] Remove internet request in unit tests
Aperta
priority: p2
type: feature request
- Lingua principale
- Java
- Stelle
- 2.1k
- Fork
- 1.2k
- Merge medio
- 1g 23h
- PR unite (30g)
- 154
Descrizione
The unit tests in `hermetic_build/release_note_generation/tests/generate_pr_description_unit_tests.py` have real `git clone` and `git checkout`. However, it is not a best practice for unit tests to depend on internet request as it is slow and flaky.
We should mock these operations to make the unit tests quick and deterministic.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.