googleapis / googleapis/google-cloud-java
[sdk-platform-java] Remove internet request in unit tests
Offen
priority: p2
type: feature request
- Vorherrschende Sprache
- Java
- Sterne
- 2.1k
- Forks
- 1.2k
- Ø Merge
- 1 T. 23 Std.
- Gemergte PRs (30 T.)
- 154
Beschreibung
The unit tests in `hermetic_build/release_note_generation/tests/generate_pr_description_unit_tests.py` have real `git clone` and `git checkout`. However, it is not a best practice for unit tests to depend on internet request as it is slow and flaky.
We should mock these operations to make the unit tests quick and deterministic.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.