getsentry / getsentry/sentry-java
profiler.id is always attached, even if ProfilingManager is rate-limiting
- 主要言語
- Kotlin
- スター
- 1.4k
- フォーク
- 478
- 平均マージ
- 2日 23時間
- マージ済み PR(30日)
- 67
説明
This has been observed for Perfetto Profiling in our demo app, where a trace had a `profiler.id` set, but the actual profile was missing.
When linking traces and profiles, we link them unconditionally, e.g. here: [https://github.com/getsentry/sentry-java/blob/bcd3e76a8033a30cf291fc84c726d40205b21db2/sentry/src/main/java/io/sentry/SentryTracer.java#L552]()
This stems from `ProfilingManager`, where requests can be rate-limited, and rejections are only reported via async profiling result. Or in other words `PerfettoProfiler.start()` will always return true, and only `processResult` at a later point will be able to detect rate limiting.
コントリビューションガイド
調査の方向性
Start at sentry/src/main/java/io/sentry/SentryTracer.java around the linked trace/profile association, then trace ProfilingManager and PerfettoProfiler.start() through processResult. Confirm how rate-limited profiling results are reported and verify that traces do not receive a profiler.id when the corresponding profile is missing.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- java
- 領域
- mobile, performance
- issue の種類
- バグ
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 静か
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 54/100