getsentry / getsentry/sentry-java
profiler.id is always attached, even if ProfilingManager is rate-limiting
- Lingua principale
- Kotlin
- Stelle
- 1.4k
- Fork
- 478
- Merge medio
- 2g 23h
- PR unite (30g)
- 67
Descrizione
This has been observed for Perfetto Profiling in our demo app, where a trace had a `profiler.id` set, but the actual profile was missing.
When linking traces and profiles, we link them unconditionally, e.g. here: [https://github.com/getsentry/sentry-java/blob/bcd3e76a8033a30cf291fc84c726d40205b21db2/sentry/src/main/java/io/sentry/SentryTracer.java#L552]()
This stems from `ProfilingManager`, where requests can be rate-limited, and rejections are only reported via async profiling result. Or in other words `PerfettoProfiler.start()` will always return true, and only `processResult` at a later point will be able to detect rate limiting.
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Start at sentry/src/main/java/io/sentry/SentryTracer.java around the linked trace/profile association, then trace ProfilingManager and PerfettoProfiler.start() through processResult. Confirm how rate-limited profiling results are reported and verify that traces do not receive a profiler.id when the corresponding profile is missing.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- java
- Ambito
- mobile, performance
- Tipo di issue
- Bug
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 54/100