getsentry / getsentry/sentry-java

profiler.id is always attached, even if ProfilingManager is rate-limiting

Abierto
#5,906 1 comentario 0 reacciones 0 asignados Ver en GitHub
Android Platform: Android Platform: Java Profiles Type: Bug
Lenguaje dominante
Kotlin
Estrellas
1.4k
Forks
478
Merge medio
2 d 23 h
PR fusionados (30 d)
67

Descripción

This has been observed for Perfetto Profiling in our demo app, where a trace had a `profiler.id` set, but the actual profile was missing.

When linking traces and profiles, we link them unconditionally, e.g. here: [https://github.com/getsentry/sentry-java/blob/bcd3e76a8033a30cf291fc84c726d40205b21db2/sentry/src/main/java/io/sentry/SentryTracer.java#L552]()

This stems from `ProfilingManager`, where requests can be rate-limited, and rejections are only reported via async profiling result. Or in other words `PerfettoProfiler.start()` will always return true, and only `processResult` at a later point will be able to detect rate limiting.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start at sentry/src/main/java/io/sentry/SentryTracer.java around the linked trace/profile association, then trace ProfilingManager and PerfettoProfiler.start() through processResult. Confirm how rate-limited profiling results are reported and verify that traces do not receive a profiler.id when the corresponding profile is missing.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
java
Área
mobile, performance
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
54/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.