getsentry / getsentry/sentry-java
profiler.id is always attached, even if ProfilingManager is rate-limiting
- 主要語言
- Kotlin
- 星號
- 1.4k
- 分支
- 478
- 平均合併
- 3 天 4 小時
- 30 天內合併 PR
- 72
描述
This has been observed for Perfetto Profiling in our demo app, where a trace had a `profiler.id` set, but the actual profile was missing.
When linking traces and profiles, we link them unconditionally, e.g. here: [https://github.com/getsentry/sentry-java/blob/bcd3e76a8033a30cf291fc84c726d40205b21db2/sentry/src/main/java/io/sentry/SentryTracer.java#L552]()
This stems from `ProfilingManager`, where requests can be rate-limited, and rejections are only reported via async profiling result. Or in other words `PerfettoProfiler.start()` will always return true, and only `processResult` at a later point will be able to detect rate limiting.
貢獻指南
研究方向
從 sentry/src/main/java/io/sentry/SentryTracer.java 中連結的 trace/profile 關聯處開始,然後追蹤 ProfilingManager 和 PerfettoProfiler.start() 直到 processResult。確認受速率限制的 profiling 結果如何回報,並驗證相應的 profile 缺失時 traces 不會取得 profiler.id。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- java
- 領域
- mobile, performance
- Issue 類型
- 缺陷
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 活躍度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 54/100