getsentry / getsentry/sentry-java

profiler.id is always attached, even if ProfilingManager is rate-limiting

Ouverte
#5,906 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Android Platform: Android Platform: Java Profiles Type: Bug
Langage dominant
Kotlin
Étoiles
1.4k
Forks
478
Merge moyen
2 j 23 h
PR mergées (30 j)
67

Description

This has been observed for Perfetto Profiling in our demo app, where a trace had a `profiler.id` set, but the actual profile was missing.

When linking traces and profiles, we link them unconditionally, e.g. here: [https://github.com/getsentry/sentry-java/blob/bcd3e76a8033a30cf291fc84c726d40205b21db2/sentry/src/main/java/io/sentry/SentryTracer.java#L552]()

This stems from `ProfilingManager`, where requests can be rate-limited, and rejections are only reported via async profiling result. Or in other words `PerfettoProfiler.start()` will always return true, and only `processResult` at a later point will be able to detect rate limiting.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start at sentry/src/main/java/io/sentry/SentryTracer.java around the linked trace/profile association, then trace ProfilingManager and PerfettoProfiler.start() through processResult. Confirm how rate-limited profiling results are reported and verify that traces do not receive a profiler.id when the corresponding profile is missing.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
java
Domaine
mobile, performance
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
54/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.