crossplane-contrib / crossplane-contrib/function-patch-and-transform

Cannot patch with CombineFromEnvironment

オープン
#68 コメント 13 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Go
スター
46
フォーク
41
平均マージ
1日 10時間
マージ済み PR(30日)
3

説明

I've migrated from a resource composition to a pipeline and have been able to get everything to work except the patching of the annotation, so it defaults to the generated name preventing the resource from being created because it is not valid for the provider

```
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
name: storage-pipeline
spec:
compositeTypeRef:
apiVersion: xxx.xxx.xxx/v1alpha1
kind: xStorage
environment:
environmentConfigs:
- type: Reference
ref:
name: global
- type: Reference
ref:
name: organization
- type: Reference
ref:
name: subscription
- type: Reference
ref:
name: product
- type: Reference
ref:
name: environment
patches:
- type: FromCompositeFieldPath
fromFieldPath: spec.identifier
toFieldPath: data.instance.identifier

mode: Pipeline
pipeline:
- step: create-storage
functionRef:
name: function-patch-and-transform
input:
apiVersion: pt.fn.crossplane.io/v1beta1
kind: Resources
resources:
- name: storage
base:
apiVersion: storage.azure.upbound.io/v1beta1
kind: Account

patches:

- type: CombineFromEnvironment
combine:
strategy: string
variables:
- fromFieldPath: organization.identifier
- fromFieldPath: subscription.identifier
- fromFieldPath: environment.code
- fromFieldPath: location.short
- fromFieldPath: product.identifier
- fromFieldPath: data.instance.identifier
string:
fmt: "%s%sst%s%s%s%s"
toFieldPath: metadata.annotations[crossplane.io/external-name]

- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountReplicationType
toFieldPath: spec.forProvider.accountReplicationType
- type: FromCompositeFieldPath
fromFieldPath: spec.accountReplicationType
toFieldPath: spec.forProvider.accountReplicationType

- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountTier
toFieldPath: spec.forProvider.accountTier
- type: FromCompositeFieldPath
fromFieldPath: spec.accountTier
toFieldPath: spec.forProvider.accountTier

- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountKind
toFieldPath: spec.forProvider.accountKind
- type: FromCompositeFieldPath
fromFieldPath: spec.accountKind
toFieldPath: spec.forProvider.accountKind

- type: FromEnvironmentFieldPath
fromFieldPath: storage.allowNestedItemsToBePublic
toFieldPath: spec.forProvider.allowNestedItemsToBePublic
- type: FromCompositeFieldPath
fromFieldPath: spec.allowNestedItemsToBePublic
toFieldPath: spec.forProvider.allowNestedItemsToBePublic

- type: FromEnvironmentFieldPath
fromFieldPath: storage.publicNetworkAccessEnabled
toFieldPath: spec.forProvider.publicNetworkAccessEnabled
- type: FromCompositeFieldPath
fromFieldPath: spec.publicNetworkAccessEnabled
toFieldPath: spec.forProvider.publicNetworkAccessEnabled

- type: FromEnvironmentFieldPath
fromFieldPath: location.long
toFieldPath: spec.forProvider.location

- type: FromEnvironmentFieldPath
fromFieldPath: product.resourceGroupName
toFieldPath: spec.forProvider.resourceGroupName

- type: ToCompositeFieldPath
fromFieldPath: status.atProvider.id
toFieldPath: status.id

```

Everything else appears to patch correctly. I also tried patching the same thing to "metadata.name" and it also does not patch.

When I run the same from a resource composition it patches as expected.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

まず、提供されたパイプライン Composition を function-patch-and-transform で再現し、CombineFromEnvironment パッチのエントリーポイントを追跡して、resource-composition の動作と比較します。metadata.annotations[crossplane.io/external-name] と metadata.name の処理を検証します。パイプライン composition でこれらのフィールドに結合された環境値が設定されれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
go
領域
infrastructure
issue の種類
バグ
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
42/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。