crossplane-contrib / crossplane-contrib/function-patch-and-transform

Cannot patch with CombineFromEnvironment

Ouverte
#68 13 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Go
Étoiles
46
Forks
41
Merge moyen
1 j 10 h
PR mergées (30 j)
3

Description

I've migrated from a resource composition to a pipeline and have been able to get everything to work except the patching of the annotation, so it defaults to the generated name preventing the resource from being created because it is not valid for the provider

```
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
name: storage-pipeline
spec:
compositeTypeRef:
apiVersion: xxx.xxx.xxx/v1alpha1
kind: xStorage
environment:
environmentConfigs:
- type: Reference
ref:
name: global
- type: Reference
ref:
name: organization
- type: Reference
ref:
name: subscription
- type: Reference
ref:
name: product
- type: Reference
ref:
name: environment
patches:
- type: FromCompositeFieldPath
fromFieldPath: spec.identifier
toFieldPath: data.instance.identifier

mode: Pipeline
pipeline:
- step: create-storage
functionRef:
name: function-patch-and-transform
input:
apiVersion: pt.fn.crossplane.io/v1beta1
kind: Resources
resources:
- name: storage
base:
apiVersion: storage.azure.upbound.io/v1beta1
kind: Account

patches:

- type: CombineFromEnvironment
combine:
strategy: string
variables:
- fromFieldPath: organization.identifier
- fromFieldPath: subscription.identifier
- fromFieldPath: environment.code
- fromFieldPath: location.short
- fromFieldPath: product.identifier
- fromFieldPath: data.instance.identifier
string:
fmt: "%s%sst%s%s%s%s"
toFieldPath: metadata.annotations[crossplane.io/external-name]

- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountReplicationType
toFieldPath: spec.forProvider.accountReplicationType
- type: FromCompositeFieldPath
fromFieldPath: spec.accountReplicationType
toFieldPath: spec.forProvider.accountReplicationType

- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountTier
toFieldPath: spec.forProvider.accountTier
- type: FromCompositeFieldPath
fromFieldPath: spec.accountTier
toFieldPath: spec.forProvider.accountTier

- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountKind
toFieldPath: spec.forProvider.accountKind
- type: FromCompositeFieldPath
fromFieldPath: spec.accountKind
toFieldPath: spec.forProvider.accountKind

- type: FromEnvironmentFieldPath
fromFieldPath: storage.allowNestedItemsToBePublic
toFieldPath: spec.forProvider.allowNestedItemsToBePublic
- type: FromCompositeFieldPath
fromFieldPath: spec.allowNestedItemsToBePublic
toFieldPath: spec.forProvider.allowNestedItemsToBePublic

- type: FromEnvironmentFieldPath
fromFieldPath: storage.publicNetworkAccessEnabled
toFieldPath: spec.forProvider.publicNetworkAccessEnabled
- type: FromCompositeFieldPath
fromFieldPath: spec.publicNetworkAccessEnabled
toFieldPath: spec.forProvider.publicNetworkAccessEnabled

- type: FromEnvironmentFieldPath
fromFieldPath: location.long
toFieldPath: spec.forProvider.location

- type: FromEnvironmentFieldPath
fromFieldPath: product.resourceGroupName
toFieldPath: spec.forProvider.resourceGroupName

- type: ToCompositeFieldPath
fromFieldPath: status.atProvider.id
toFieldPath: status.id

```

Everything else appears to patch correctly. I also tried patching the same thing to "metadata.name" and it also does not patch.

When I run the same from a resource composition it patches as expected.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Commencez par reproduire la Composition de pipeline fournie dans function-patch-and-transform et suivez le point d’entrée du patch CombineFromEnvironment, en le comparant au comportement de resource-composition. Vérifiez la gestion de metadata.annotations[crossplane.io/external-name] et de metadata.name ; le travail est terminé lorsque ces champs reçoivent la valeur d’environnement combinée dans une composition de pipeline.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
go
Domaine
infrastructure
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
42/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.