crossplane-contrib / crossplane-contrib/function-patch-and-transform

Cannot patch with CombineFromEnvironment

Aperta
#68 13 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Go
Stelle
46
Fork
41
Merge medio
1g 10h
PR unite (30g)
3

Descrizione

I've migrated from a resource composition to a pipeline and have been able to get everything to work except the patching of the annotation, so it defaults to the generated name preventing the resource from being created because it is not valid for the provider

```
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
name: storage-pipeline
spec:
compositeTypeRef:
apiVersion: xxx.xxx.xxx/v1alpha1
kind: xStorage
environment:
environmentConfigs:
- type: Reference
ref:
name: global
- type: Reference
ref:
name: organization
- type: Reference
ref:
name: subscription
- type: Reference
ref:
name: product
- type: Reference
ref:
name: environment
patches:
- type: FromCompositeFieldPath
fromFieldPath: spec.identifier
toFieldPath: data.instance.identifier

mode: Pipeline
pipeline:
- step: create-storage
functionRef:
name: function-patch-and-transform
input:
apiVersion: pt.fn.crossplane.io/v1beta1
kind: Resources
resources:
- name: storage
base:
apiVersion: storage.azure.upbound.io/v1beta1
kind: Account

patches:

- type: CombineFromEnvironment
combine:
strategy: string
variables:
- fromFieldPath: organization.identifier
- fromFieldPath: subscription.identifier
- fromFieldPath: environment.code
- fromFieldPath: location.short
- fromFieldPath: product.identifier
- fromFieldPath: data.instance.identifier
string:
fmt: "%s%sst%s%s%s%s"
toFieldPath: metadata.annotations[crossplane.io/external-name]

- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountReplicationType
toFieldPath: spec.forProvider.accountReplicationType
- type: FromCompositeFieldPath
fromFieldPath: spec.accountReplicationType
toFieldPath: spec.forProvider.accountReplicationType

- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountTier
toFieldPath: spec.forProvider.accountTier
- type: FromCompositeFieldPath
fromFieldPath: spec.accountTier
toFieldPath: spec.forProvider.accountTier

- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountKind
toFieldPath: spec.forProvider.accountKind
- type: FromCompositeFieldPath
fromFieldPath: spec.accountKind
toFieldPath: spec.forProvider.accountKind

- type: FromEnvironmentFieldPath
fromFieldPath: storage.allowNestedItemsToBePublic
toFieldPath: spec.forProvider.allowNestedItemsToBePublic
- type: FromCompositeFieldPath
fromFieldPath: spec.allowNestedItemsToBePublic
toFieldPath: spec.forProvider.allowNestedItemsToBePublic

- type: FromEnvironmentFieldPath
fromFieldPath: storage.publicNetworkAccessEnabled
toFieldPath: spec.forProvider.publicNetworkAccessEnabled
- type: FromCompositeFieldPath
fromFieldPath: spec.publicNetworkAccessEnabled
toFieldPath: spec.forProvider.publicNetworkAccessEnabled

- type: FromEnvironmentFieldPath
fromFieldPath: location.long
toFieldPath: spec.forProvider.location

- type: FromEnvironmentFieldPath
fromFieldPath: product.resourceGroupName
toFieldPath: spec.forProvider.resourceGroupName

- type: ToCompositeFieldPath
fromFieldPath: status.atProvider.id
toFieldPath: status.id

```

Everything else appears to patch correctly. I also tried patching the same thing to "metadata.name" and it also does not patch.

When I run the same from a resource composition it patches as expected.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Inizia riproducendo la Composition della pipeline fornita in function-patch-and-transform e traccia il punto di ingresso della patch CombineFromEnvironment, confrontandolo con il comportamento di resource-composition. Verifica la gestione di metadata.annotations[crossplane.io/external-name] e metadata.name; il lavoro è completato quando questi campi ricevono il valore dell’ambiente combinato in una composition della pipeline.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
go
Ambito
infrastructure
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
42/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.