crossplane-contrib / crossplane-contrib/function-patch-and-transform
Cannot patch with CombineFromEnvironment
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 46
- Forks
- 41
- Merge medio
- 1 d 10 h
- PR fusionados (30 d)
- 3
Descripción
I've migrated from a resource composition to a pipeline and have been able to get everything to work except the patching of the annotation, so it defaults to the generated name preventing the resource from being created because it is not valid for the provider
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
name: storage-pipeline
spec:
compositeTypeRef:
apiVersion: xxx.xxx.xxx/v1alpha1
kind: xStorage
environment:
environmentConfigs:
- type: Reference
ref:
name: global
- type: Reference
ref:
name: organization
- type: Reference
ref:
name: subscription
- type: Reference
ref:
name: product
- type: Reference
ref:
name: environment
patches:
- type: FromCompositeFieldPath
fromFieldPath: spec.identifier
toFieldPath: data.instance.identifier
mode: Pipeline
pipeline:
- step: create-storage
functionRef:
name: function-patch-and-transform
input:
apiVersion: pt.fn.crossplane.io/v1beta1
kind: Resources
resources:
- name: storage
base:
apiVersion: storage.azure.upbound.io/v1beta1
kind: Account
patches:
- type: CombineFromEnvironment
combine:
strategy: string
variables:
- fromFieldPath: organization.identifier
- fromFieldPath: subscription.identifier
- fromFieldPath: environment.code
- fromFieldPath: location.short
- fromFieldPath: product.identifier
- fromFieldPath: data.instance.identifier
string:
fmt: "%s%sst%s%s%s%s"
toFieldPath: metadata.annotations[crossplane.io/external-name]
- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountReplicationType
toFieldPath: spec.forProvider.accountReplicationType
- type: FromCompositeFieldPath
fromFieldPath: spec.accountReplicationType
toFieldPath: spec.forProvider.accountReplicationType
- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountTier
toFieldPath: spec.forProvider.accountTier
- type: FromCompositeFieldPath
fromFieldPath: spec.accountTier
toFieldPath: spec.forProvider.accountTier
- type: FromEnvironmentFieldPath
fromFieldPath: storage.accountKind
toFieldPath: spec.forProvider.accountKind
- type: FromCompositeFieldPath
fromFieldPath: spec.accountKind
toFieldPath: spec.forProvider.accountKind
- type: FromEnvironmentFieldPath
fromFieldPath: storage.allowNestedItemsToBePublic
toFieldPath: spec.forProvider.allowNestedItemsToBePublic
- type: FromCompositeFieldPath
fromFieldPath: spec.allowNestedItemsToBePublic
toFieldPath: spec.forProvider.allowNestedItemsToBePublic
- type: FromEnvironmentFieldPath
fromFieldPath: storage.publicNetworkAccessEnabled
toFieldPath: spec.forProvider.publicNetworkAccessEnabled
- type: FromCompositeFieldPath
fromFieldPath: spec.publicNetworkAccessEnabled
toFieldPath: spec.forProvider.publicNetworkAccessEnabled
- type: FromEnvironmentFieldPath
fromFieldPath: location.long
toFieldPath: spec.forProvider.location
- type: FromEnvironmentFieldPath
fromFieldPath: product.resourceGroupName
toFieldPath: spec.forProvider.resourceGroupName
- type: ToCompositeFieldPath
fromFieldPath: status.atProvider.id
toFieldPath: status.id
Everything else appears to patch correctly. I also tried patching the same thing to "metadata.name" and it also does not patch.
When I run the same from a resource composition it patches as expected.
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza reproduciendo la Composition de pipeline proporcionada en function-patch-and-transform y sigue el punto de entrada del parche CombineFromEnvironment, comparándolo con el comportamiento de resource-composition. Verifica el manejo de metadata.annotations[crossplane.io/external-name] y metadata.name; se considera terminado cuando estos campos reciben el valor de entorno combinado en una composición de pipeline.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- go
- Área
- infrastructure
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 42/100