code-corps / code-corps/code-corps-ember
Description of a category item does not change color on selection
Đang mở
bug
Difficulty: Easy
- Ngôn ngữ chính
- JavaScript
- Star
- 120
- Fork
- 75
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
# Problem
From https://github.com/code-corps/code-corps-ember/pull/1079#discussion_r102404681
>The `description` text is always using the `$text--light` (`#666`) color and does not switch to `$default-color` (`#08A8FC` when selected.
The PR introduced a minor bug. The `iconClass` is bound to the icon element alone and nothing is bound to the `p` element which holds the description. That means that the `p.selected` style can no longer apply.
The component itself should be bound to the `iconClass` class property and styles should be rewritten so they apply to both the icon and the `p` element.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.