code-corps / code-corps/code-corps-ember

Description of a category item does not change color on selection

未关闭
#1,092 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug Difficulty: Easy
主要语言
JavaScript
星标
120
派生
75
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

From https://github.com/code-corps/code-corps-ember/pull/1079#discussion_r102404681

>The `description` text is always using the `$text--light` (`#666`) color and does not switch to `$default-color` (`#08A8FC` when selected.

The PR introduced a minor bug. The `iconClass` is bound to the icon element alone and nothing is bound to the `p` element which holds the description. That means that the `p.selected` style can no longer apply.

The component itself should be bound to the `iconClass` class property and styles should be rewritten so they apply to both the icon and the `p` element.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。