code-corps / code-corps/code-corps-ember

Description of a category item does not change color on selection

Abierto
#1,092 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug Difficulty: Easy
Lenguaje dominante
JavaScript
Estrellas
120
Forks
75
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

# Problem

From https://github.com/code-corps/code-corps-ember/pull/1079#discussion_r102404681

>The `description` text is always using the `$text--light` (`#666`) color and does not switch to `$default-color` (`#08A8FC` when selected.

The PR introduced a minor bug. The `iconClass` is bound to the icon element alone and nothing is bound to the `p` element which holds the description. That means that the `p.selected` style can no longer apply.

The component itself should be bound to the `iconClass` class property and styles should be rewritten so they apply to both the icon and the `p` element.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.