code-corps / code-corps/code-corps-ember

Description of a category item does not change color on selection

Ouverte
#1,092 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug Difficulty: Easy
Langage dominant
JavaScript
Étoiles
120
Forks
75
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

# Problem

From https://github.com/code-corps/code-corps-ember/pull/1079#discussion_r102404681

>The `description` text is always using the `$text--light` (`#666`) color and does not switch to `$default-color` (`#08A8FC` when selected.

The PR introduced a minor bug. The `iconClass` is bound to the icon element alone and nothing is bound to the `p` element which holds the description. That means that the `p.selected` style can no longer apply.

The component itself should be bound to the `iconClass` class property and styles should be rewritten so they apply to both the icon and the `p` element.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.