bluerobotics / bluerobotics/ping-cpp

Ping360 example uses auto messages without checking protocol support

Open
#65 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
19
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Ping-protocol v1.1 introduced support for [auto transmission](https://docs.bluerobotics.com/ping-protocol/pingmessage-ping360/#2602-auto_transmit) for the ping360 message set, which [our example](https://github.com/bluerobotics/ping-cpp/blob/master/test/test-device-ping360.cpp#L56) uses without checking that the device is capable of handling and sending the relevant messages.

Ideally it should check the protocol version and fall back to only manual messages if relevant.
[Raised/discussed here](https://discuss.bluerobotics.com/t/obtaining-raw-data-from-the-ping360-using-ping-cpp/19573/2).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in test/test-device-ping360.cpp at the linked example and review the Ping-protocol v1.1 auto-transmission documentation. Add a protocol-capability check so unsupported devices use only manual messages, then verify the example's behavior for devices that do and do not support the relevant messages.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.