bluerobotics / bluerobotics/ping-cpp

Ping360 example uses auto messages without checking protocol support

Open
#65 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
19
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Ping-protocol v1.1 introduced support for [auto transmission](https://docs.bluerobotics.com/ping-protocol/pingmessage-ping360/#2602-auto_transmit) for the ping360 message set, which [our example](https://github.com/bluerobotics/ping-cpp/blob/master/test/test-device-ping360.cpp#L56) uses without checking that the device is capable of handling and sending the relevant messages.

Ideally it should check the protocol version and fall back to only manual messages if relevant.
[Raised/discussed here](https://discuss.bluerobotics.com/t/obtaining-raw-data-from-the-ping360-using-ping-cpp/19573/2).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.