the method `importVirtualMachineInternal(..)` now is 153 lines and takes 21 parameters.
Đang mở
long-term-plan
no-issue-activity
type:technical-debt
- Ngôn ngữ chính
- Java
- Star
- 3.1k
- Fork
- 1.4k
- Merge trung bình
- 6 ngày 19 giờ
- Pull request đã merge (30 ngày)
- 32
Mô tả
logic looks good, but the code here needs some refactorring I think (new PR?) the method now is 153 lines and takes 21 parameters. Not sure about cyclic complexity and I really don’t want to know anymore by now.
_Originally posted by @DaanHoogland in https://github.com/apache/cloudstack/pull/10975#pullrequestreview-2931850389_
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.