the method `importVirtualMachineInternal(..)` now is 153 lines and takes 21 parameters.
未關閉
long-term-plan
no-issue-activity
type:technical-debt
- 主要語言
- Java
- 星號
- 3.1k
- 分支
- 1.4k
- 平均合併
- 6 天 19 小時
- 30 天內合併 PR
- 32
描述
logic looks good, but the code here needs some refactorring I think (new PR?) the method now is 153 lines and takes 21 parameters. Not sure about cyclic complexity and I really don’t want to know anymore by now.
_Originally posted by @DaanHoogland in https://github.com/apache/cloudstack/pull/10975#pullrequestreview-2931850389_
貢獻指南
評估
這個 Issue 還沒有評估資料。