the method `importVirtualMachineInternal(..)` now is 153 lines and takes 21 parameters.
未关闭
long-term-plan
no-issue-activity
type:technical-debt
- 主要语言
- Java
- 星标
- 3.1k
- 派生
- 1.4k
- 平均合并
- 6 天 19 小时
- 30 天内合并 PR
- 32
描述
logic looks good, but the code here needs some refactorring I think (new PR?) the method now is 153 lines and takes 21 parameters. Not sure about cyclic complexity and I really don’t want to know anymore by now.
_Originally posted by @DaanHoogland in https://github.com/apache/cloudstack/pull/10975#pullrequestreview-2931850389_
贡献指南
评估
这个 Issue 还没有评估数据。